fix: resolve multiple bugs#554
Open
laraba9987-cmyk wants to merge 2 commits into
Open
Conversation
- Remove hardcoded webhook fallback secret (MettaChain#421) - Fix duplicate transaction tables in TransactionHistory (MettaChain#423) - Add proper error logging to silent catch blocks (MettaChain#425) - Create useSafeTimeout hook and fix uncleared timeouts (MettaChain#426) Closes MettaChain#421, MettaChain#423, MettaChain#425, MettaChain#426
|
@laraba9987-cmyk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #421,
Closes #423,
Closes #425,
Closes #426
#421 - Remove hardcoded webhook fallback secret
Removed the insecure fallback string literal in
src/app/api/revalidate/route.ts. Now throws a clear error ifREVALIDATE_WEBHOOK_SECRETis unset. Updated.env.example.#423 - Fix duplicate transaction tables
Removed duplicate table block in
src/components/TransactionHistory.tsx. Pagination now points to the single canonical table.#425 - Add error logging to silent catch blocks
Added
logger.warn/logger.errorcalls to empty catch blocks inblockchainSecurity.ts,phishingProtection.ts,walletHelpers.ts,useSearchHistory.ts,useCurrencyConverter.ts,ViewToggle.tsx.#426 - Fix unclear setTimeout calls
Created
src/hooks/useSafeTimeout.tshook. Replaced baresetTimeoutcalls in 10 components to auto-cleanup on unmount.